[FFmpeg-devel] [PATCH]Allow >2G for skip_initial_bytes

[Hendrik Leppkes]

On Thu, Jun 5, 2014 at 11:56 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Jun 05, 2014 at 11:13:37PM +0200, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch allows larger values for -skip_initial_bytes.
>>
>> Please comment, Carl Eugen
>
>>  avformat.h      |   12 +++++++++---
>>  options_table.h |    2 +-
>>  utils.c         |    1 +
>>  3 files changed, 11 insertions(+), 4 deletions(-)
>> 1a5d9b5e4e2960a8ff444ebcb3efd57e4063fc48  patchinitialbytes.diff
>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
>> index 01c3b75..f3b6614 100644
>> --- a/libavformat/avformat.h
>> +++ b/libavformat/avformat.h
>> @@ -1494,10 +1494,9 @@ typedef struct AVFormatContext {
>>      enum AVDurationEstimationMethod duration_estimation_method;
>>
>>      /**
>> -     * Skip initial bytes when opening stream
>> -     * - encoding: unused
>> -     * - decoding: Set by user via AVOptions (NO direct access)
>> +     * @deprecated deprecated in favor of skip_initial_bytes2()
>>       */
>> +    attribute_deprecated
>>      unsigned int skip_initial_bytes;
>
> i think you can remove this field
> that is if all fields afterwards are internal / "NO direct access"
>
> patch LGTM


If its entirely internal, and all following fields are as well, and
thus not part of the ABI, you could as well just change its type, and
not bother with a new "2" field.

- Hendrik