[FFmpeg-devel] [PATCH] libx265: Update bitrate in avcontext in case it was overriden by x265 specific options

[Derek Buitenhuis]

On 6/13/2014 2:31 PM, Nicolas Morey-Chaisemartin wrote:
> Sorry for the style. First time looking into ffmpeg code :)
> 
> I guess it could be unconditional too but it didn't seem to make much sense to copy the target bitrate if we use CQP or CRF modes.

This is true.

> The issue behind this is when a user passes something like -x265-params bitrate=10000 on the command line, ffmpeg summary still outputs something like this:
> 
> Output #0, hevc, to 'output.hevc':
>    Metadata:
>      encoder         : Lavf55.33.100
>      Stream #0:0: Video: hevc (libx265), yuv420p, 1280x720 [SAR 1:1 DAR 16:9], q=2-31, *200 kb/s*, 90k tbn, 50 tbc
> 
> Although the right target bitrate is used, the message is a bit unsettling for end users :)

I'm more thinking, what are the consequences for API users?

https://www.ffmpeg.org/doxygen/trunk/structAVCodecContext.html#ad9214d5af3e98ea7f1d4e94be6a522de

The doxygen says set by user -- are we even allowed to change it?

Perhaps I am over-thinking this.

> On another subject, is it the wanted behavior to silently ignore x265-params string if av_dict_parse_string fails?
> x264 wrapper does the same but it's a real hassle to figure out why option keep being ignored !

I suppose it could print a warning about garbage strings being supplied.

- Derek