[FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

[Carl Eugen Hoyos]

Clément Bœsch <u <at> pkh.me> writes:

> I'm also not sure about what happens if opencl is linked 
> against libx264 but only a .a/.so of opencl is available.

Opencl with static library is the only case that doesn't 
currently work without an additional -l linker flag.

> We can document PKG_CONFIG_PATH in that configure help 
> if that makes you more comfortable.

It is not about making me more comfortable, the 
patch needs it to give users a chance to understand the 
change.

> > I meant I hate to install a custom x264 build.

Let me try again since this is apparently unclear:
If I need FFmpeg with a particular x264 build, I 
compile x264 and prefer not to run "make install". 
This would be broken by your patch.

If your patch is really what everybody wants, please 
add a fallback that allows to try the current 
way of building if pkg-config returns that the 
library is missing.

Carl Eugen