[FFmpeg-devel] intent of 'lsf' variable in libavformat/mp3enc.c mp3_write_xing() ?

[Jason Vas Dias]

On Thursday 19 June 2014 21:23:07 Michael Niedermayer wrote:
> Hi
> 
> On Thu, Jun 19, 2014 at 07:07:02PM +0100, Jason Vas Dias wrote:
> > Thanks for responding, Michael -
> > Actually, I checked out the GIT HEAD, then checked out the latest 'stable'
> > tag 'n2.2.3'. Sorry, my original mail should have mentioned the version I
> > was trying to build.
> it seems we forgot backporting the bugfix for this
> 
> Fixed in release/2.2
> 
> thanks
> 
> [...]

Hi Michael -
  
   But what was the fix for this ? How should 'lsf' be initialized - is '0' OK ?

   I've attached a patch against the files with the 'n2.2.3' tag to fix all the other 
   compiler warnings (some of which, about '{0}' not initializing structures, are
   due to Red Hat gcc-4.4.7 bug https://bugzilla.redhat.com/show_bug.cgi?id=1110870 ) -
   but most of which  are valid & 99% are about uninitialized variables .   I hope most
   of them are fixed in GIT HEAD & will make it into the next 'stable' release, & that
   you might find the patches useful.
 
Regards,
Jason 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-2_2_3_compiler_warnings.patch
Type: text/x-patch
Size: 24499 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140620/f6a846b6/attachment.bin>