[FFmpeg-devel] [PATCH] avfilter: add hqx filter (hq2x, hq3x, hq4x)

[Clément Bœsch]

On Sat, Jun 21, 2014 at 05:48:53PM +0200, Stefano Sabatini wrote:
[...]
> > +High-quality magnification filter designed for pixel art, originally created by
> > +Maxim Stepin.
> 
> Apply high-quality magnification ... This filter was originally
> created by ...
> 

changed.

[...]
> > +/*
> > + * Copyright (c) 2014 Clément Bœsch
> > + *
> 
> In case you adopted the design/implementation of existing code you
> should probably add the original authors here, or refer the reference.
> 

The code is completely different. I mentioned the author of the algorithm
in the documentation and just added a reference to him in the @file.

[...]
> > +/* m is the mask of diff with the center pixel that matters in the pattern, and
> > + * r is the expected result (bit set to 1 if there is difference with the
> > + * center, 0 otherwise */
> 
> nit++++: close parenthesis
> 

not a nit, you're correct here, fixed.

> [...]
> 
> LGTM without looking closer into the algorithm, should be good
> assuming it has the same behavior as the reference code.

Thanks to you & Paul. Applied.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140621/f37cad4a/attachment.asc>