[FFmpeg-devel] [PATCH] lavd: add missing guards and includes to decklink_enc.h

James Almer jamrial at gmail.com
Thu Mar 6 05:46:30 CET 2014


On 06/03/14 1:37 AM, Michael Niedermayer wrote:
> On Sun, Feb 16, 2014 at 03:46:57PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavdevice/decklink_enc.h | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/libavdevice/decklink_enc.h b/libavdevice/decklink_enc.h
>> index 0b9ad8f..72e7d28 100644
>> --- a/libavdevice/decklink_enc.h
>> +++ b/libavdevice/decklink_enc.h
>> @@ -19,6 +19,11 @@
>>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>>   */
>>  
>> +#ifndef AVDEVICE_DECKLINK_ENC_H
>> +#define AVDEVICE_DECKLINK_ENC_H
>> +
> 
>> +#include "avdevice.h"
> 
> should this not be inside the extern C stuff ?
> 
> CCing ramiro
> btw, ramiro maybe you want to add yourself to MAINTAINERs for decklink
> 

The decklink_cctx struct is outside the extern C stuff, and it needs avdevice.h

No idea if that struct should also be inside the extern. I just noticed the 
header was lacking the usual guards and a header include for the prototypes so 
i added them.


More information about the ffmpeg-devel mailing list