[FFmpeg-devel] [RFC]Remote fate

[Michael Niedermayer]

On Sun, Mar 16, 2014 at 11:31:13AM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes some of the problems when running fate on a
> remote target with --target-exec
> 
> Please comment, Carl Eugen

>  ffmpeg.mak       |   10 +++++-----
>  filter-audio.mak |    2 +-
>  filter-video.mak |    4 ++--
>  gif.mak          |    2 +-
>  4 files changed, 9 insertions(+), 9 deletions(-)
> 27db88c1358290640348cf6ffe42bbfa50d3fe72  patchtargetfate.diff
> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> index 21cdd5f..3172b53
> --- a/tests/fate/ffmpeg.mak
> +++ b/tests/fate/ffmpeg.mak
> @@ -29,20 +29,20 @@ fate-force_key_frames: CMD = enc_dec \
>    framecrc "" "" "-skip_frame nokey"
>  
>  FATE_SAMPLES_FFMPEG-$(call ALLYES, VOBSUB_DEMUXER DVDSUB_DECODER AVFILTER OVERLAY_FILTER DVDSUB_ENCODER) += fate-sub2video
> -fate-sub2video: tests/data/vsynth2.yuv
> +fate-sub2video: $(TARGET_PATH)/tests/data/vsynth2.yuv
>  fate-sub2video: CMD = framecrc \

this looks wrong


> -  -f rawvideo -r 5 -s 352x288 -pix_fmt yuv420p -i tests/data/vsynth2.yuv \
> +  -f rawvideo -r 5 -s 352x288 -pix_fmt yuv420p -i $(TARGET_PATH)/tests/data/vsynth2.yuv \
>    -ss 132 -i $(SAMPLES)/sub/vobsub.idx \

ok


> -  -filter_complex "sws_flags=+accurate_rnd+bitexact;[0:0]scale=720:480[v];[v][1:0]overlay[v2]" \
> +  -filter_complex '"sws_flags=+accurate_rnd+bitexact;[0:0]scale=720:480[v];[v][1:0]overlay[v2]"' \
>    -map "[v2]" -c:v rawvideo -map 1:s -c:s dvdsub

this should be a seperate patch

rest of the patch LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140316/67a2dcec/attachment.asc>