[FFmpeg-devel] [PATCH] x86: convert DNxHDenc inline asm to yasm

[wm4]

On Wed, 26 Mar 2014 03:36:15 -0300
James Almer <jamrial at gmail.com> wrote:

> On 26/03/14 12:21 AM, Timothy Gu wrote:
> > Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> > ---
> > First asm patch...
> > ---
> >  libavcodec/x86/Makefile        |  3 +-
> >  libavcodec/x86/dnxhdenc.asm    | 50 +++++++++++++++++++++++++++++++
> >  libavcodec/x86/dnxhdenc.c      | 67 ------------------------------------------
> >  libavcodec/x86/dnxhdenc_init.c | 39 ++++++++++++++++++++++++
> >  4 files changed, 91 insertions(+), 68 deletions(-)
> >  create mode 100644 libavcodec/x86/dnxhdenc.asm
> >  delete mode 100644 libavcodec/x86/dnxhdenc.c
> >  create mode 100644 libavcodec/x86/dnxhdenc_init.c
> 
> I think it makes more sense moving this to DSPContext (And therefore to dsputilenc.asm).
> DNXHDEncContext already uses several DSPContext functions, and this get_pixels_8x4_sym
> function is generic enough (And very similar to other get_pixel ones) that it should 
> probably be there as well.

Can I ask what's the point of moving everything into a big context,
when it doesn't even help to reduce code duplication? (Maybe I'm a
bit nosy here, but I'm just wondering.)