[FFmpeg-devel] duplicate symbols and DECLARE_ASM_CONST

[Michael Niedermayer]

On Fri, May 09, 2014 at 03:19:35PM +1000, Matt Oliver wrote:
> On 9 May 2014 11:18, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Hi
> >
> > I think the use of DECLARE_ASM_CONST in libmpcodecs for dither breaks
> > suncc
> >
> > http://fate.ffmpeg.org/log.cgi?time=20140509002240&log=compile&slot=x86-opensolaris-suncc5.10
> 
> 
> It appears that the definition of DECLARE_ASM_CONST for suncc (declared
> mem.h line=44) doesn't include a static like all other definitions. I don't
> have suncc myself so I don't know why it would be declared without the
> static but because it is then the declarations of dither in vf_fspp.c,
> vf_pp7, vf_uspp are given global visibility instead of local and hence
> causing errors.
> 
> Adding the static should fix this. Im not sure why suncc doesn't have the
> static already in its DECLARE_ASM_CONST but given that for instance dither
> is declared in vf_owdenoise.c with an explicit static
> through DECLARE_ALIGNED(8, static const uint8_t, dither) and this doesn't
> generate an error with suncc (at least you haven't mentioned one) so ill
> assume that its safe to do here as well.

>  vf_fspp.c |    2 +-
>  vf_pp7.c  |    2 +-
>  vf_uspp.c |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 4a86d64dd0649c32995e6adb2530d3c822935cfb  libmpcodecs-Fix-compilation-due-to-missing-static-in.patch
> From dcb6c1b14dcabce0ec5e9427e296b811fedd865e Mon Sep 17 00:00:00 2001
> From: Matt Oliver <protogonoi at gmail.com>
> Date: Fri, 9 May 2014 15:01:14 +1000
> Subject: [PATCH] libmpcodecs: Fix compilation due to missing static in suncc.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140509/fc79b98c/attachment.asc>