[FFmpeg-devel] [PATCH] avfilter/vf_lut3d: check size in parse_dat()

[Clément Bœsch]

On Sat, May 10, 2014 at 04:26:53AM +0200, Michael Niedermayer wrote:
> Fixes CID1212261
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavfilter/vf_lut3d.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
> index 85e270c..7b2f83f 100644
> --- a/libavfilter/vf_lut3d.c
> +++ b/libavfilter/vf_lut3d.c
> @@ -274,7 +274,12 @@ static int parse_dat(AVFilterContext *ctx, FILE *f)
>  
>      NEXT_LINE(skip_line(line));
>      if (!strncmp(line, "3DLUTSIZE ", 10)) {
> -        lut3d->lutsize = size = strtol(line + 10, NULL, 0);
> +        size = strtol(line + 10, NULL, 0);
> +        if (size < 2 || size > MAX_LEVEL) {
> +            av_log(ctx, AV_LOG_ERROR, "Too large or invalid 3D LUT size\n");
> +            return AVERROR(EINVAL);
> +        }
> +        lut3d->lutsize = size;

LGTM, thanks

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140510/ee6f1127/attachment.asc>