[FFmpeg-devel] [PATCH] EBU Tech 3285 – Supplement 3 - Peak Envelope Chunk encoder

[Georg Lippitsch]

Am 11.05.2014, 17:19 Uhr, schrieb Carl Eugen Hoyos <cehoyos at ag.or.at>:

> Georg Lippitsch <georg.lippitsch <at> gmx.at> writes:
>
>> -    /* format header */
>> -    fmt = ff_start_tag(pb, "fmt ");
>> -    if (ff_put_wav_header(pb, s->streams[0]->codec, 0) < 0) {
>
>> +    if (wav->write_peak != 2) {
>
>> +        /* format header */
>> +        fmt = ff_start_tag(pb, "fmt ");
>> +        if (ff_put_wav_header(pb, s->streams[0]->codec, 0) < 0) {
>
> It makes reviewing the patch much easier if you don't reindent
> these lines in the same commit: Just leave them where they
> are now.

You mean simply not indent the whole block? Wouldn't that make the code  
much more ugly?


> Could you confirm that fate passes with your patch applied?
> (I didn't test.)

Yes, fate still passes.


Georg