[FFmpeg-devel] [PATCH] libavformat: libavformat: output cues for each subtitle block in MKV muxer

[John Peebles]

> This patch doesn't apply on FFmpeg git master.
The new version attached should apply.

> please do not include re-indent change into the patch
done

> Can you also provide a sample and command line to reproduce?
Sure.
(1) Download the attached same-time-script.mkv file. Note that while
this file only contains a subtitle track in order to keep the file size
down,
the bug still happens even if there are other tracks.
(2) Run ffmpeg -i same-time-script.ass -c copy -map 0 bad.mkv
(3) Inspect the ebml data in bad.mkv. Notice that while there are two
subtitle blocks (one for each of two different subtitles), there is only a
CueTrackPositions element for the first block. There should be one for
each block.

> Is the issue you are fixing the same as ticket #3149?
No, this patch only deals with cues for subtitle tracks, not audio tracks.


On Sun, May 25, 2014 at 5:20 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> John Peebles <johnpeeb <at> gmail.com> writes:
>
> > If you use ffmpeg to remux an mkv file and the file
> > has ASS subtitles, only the first subtitle with a
> > given timecode will be added to the list of cues.
>
> Is the issue you are fixing the same as ticket #3149?
> If yes, please add "Fixes ticket #3149" to the
> commit message.
>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libavformat-output-cues-for-each-subtitle-block-in-M.patch
Type: application/octet-stream
Size: 7620 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140525/e69dac68/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: same-time-script.mkv
Type: video/x-matroska
Size: 6740 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140525/e69dac68/attachment.mkv>