[FFmpeg-devel] [PATCH] x86: hevc_mc: better register allocation
Michael Niedermayer
michaelni at gmx.at
Wed May 28 18:45:58 CEST 2014
On Sun, May 18, 2014 at 04:57:15PM +0200, Christophe Gisquet wrote:
> Hi,
>
> 2014-05-18 15:31 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> > did you intend to attach a patch to this mail ? because i dont see
> > an attachment
>
> woops.
>
> --
> Christophe
> hevc_mc.asm | 79 ++++++++++++++++++++++++++++++++++++------------------------
> 1 file changed, 48 insertions(+), 31 deletions(-)
> 410e0e7a2a7ec3cdf400dd7ed879c49fab832d49 0001-x86-hevc_mc-better-register-allocation.patch
> From ce3488687be0dcd5a07a40831910ccfa63097754 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Sat, 17 May 2014 12:22:39 +0200
> Subject: [PATCH 1/2] x86: hevc_mc: better register allocation
>
> The xmm reg count was incorrect, and manual loading of the gprs
> furthermore allows to noticeable reduce the number needed.
>
> The modified functions are used in weighted prediction, so only a
> few samples like WP_* exhibit a change. For this one and Win64
> (some widths removed because of too few occurrences):
>
> WP_A_Toshiba_3.bit, ff_hevc_put_hevc_uni_w
> 16 32
> before: 2194 3872
> after: 2119 3767
>
> WP_B_Toshiba_3.bit, ff_hevc_put_hevc_bi_w
> 16 32 64
> before: 2819 4960 9396
> after: 2617 4788 9150
> ---
> libavcodec/x86/hevc_mc.asm | 79 ++++++++++++++++++++++++++++------------------
> 1 file changed, 48 insertions(+), 31 deletions(-)
hmm, its a bit ugly with the platform ABI ifs but noone else
commenting ...
so applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140528/eecf4621/attachment.asc>
More information about the ffmpeg-devel
mailing list