[FFmpeg-devel] [PATCH 6/6] x86: huffyuvdsp: fewer functions for x86_64

[Christophe Gisquet]

Hi,

2014-05-30 17:27 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
>> When there are 2 functions that are <= SSE2, only one is needed for x86_64.
>
> is it worth the extra %if ?

Do you mean code clutter? Quoting Ronald:
"""
As long as all this is under ARCH_X86_32 (it is in this patch), I don't
mind. I mean, people still actively develop mod decoders, that stuff is
even older.
"""

I'd consider good practice to try and reduce total object size.
Granted, it's not 1KB saved in a 75MB debug build that's going to
change anything, but still, it slightly decreases my worries about my
slow laptop hard drive. :)

-- 
Christophe