[FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

wm4 nfxjfg at googlemail.com
Sat Nov 1 15:21:29 CET 2014


On Sat, 1 Nov 2014 15:13:17 +0100
Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> On Sat, Nov 01, 2014 at 01:52:17PM +0100, wm4 wrote:
> > On Sat,  1 Nov 2014 13:45:46 +0100
> > Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> > 
> > > This is a regression, previous code did not require
> > > users to set the profile to use VDPAU.
> > 
> > It still doesn't...?
> 
> It does if you want the hwaccel API.
> 
> > There are basically 3 ffmpeg vdpau hwaccel APIs now.
> 
> (possibly 4 depending on how you could, but)
> Adding the newest one because of this code had the
> side-effect that you now need to set the profile
> even for the older ones (not for the oldest one
> using mpeg4_vdpau though it seems?).
> Obviously it would be possible to just skip this in the
> case of the older API, but as said I see no good reason.

That seems indeed like a bug, then. It would mean every API user got
broken. Nice job, Libav.


More information about the ffmpeg-devel mailing list