[FFmpeg-devel] [PATCH 1/4] ffserver_config: drop requirement video size being multiple of 16

[Michael Niedermayer]

On Sat, Nov 08, 2014 at 06:17:07PM +0100, Lukasz Marek wrote:
> On 1 November 2014 22:20, Reynaldo H. Verdejo Pinochet <
> reynaldo at osg.samsung.com> wrote:
> 
> > Hi
> >
> > On 10/31/2014 11:00 PM, Lukasz Marek wrote:
> > > [..]
> > > diff --git a/ffserver_config.c b/ffserver_config.c
> > > index d589ff2..f11db03 100644
> > > --- a/ffserver_config.c
> > > +++ b/ffserver_config.c
> > > @@ -819,8 +819,6 @@ static int
> > ffserver_parse_config_stream(FFServerConfig *config, const char *cmd,
> > >          ret = av_parse_video_size(&w, &h, arg);
> > >          if (ret < 0)
> > >              ERROR("Invalid video size '%s'\n", arg);
> > > -        else if ((w % 16) || (h % 16))
> > > -            ERROR("Image size must be a multiple of 16\n");
> > > [..]
> >
> > OK if always safe. Otherwise demote to WARNING()
> >
> > Feel free to push otherwise.
> >
> 
> Can some one confirm it is safe to not demand width and height to be
> multiply of 16? Is there any other constraint? like %2?

arbitrary dimensions should be safe, codecs which dont support them
should fail
of course there might be bugs and testing can never hurt ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141108/be59a117/attachment.asc>