[FFmpeg-devel] Fwd: [PATCH] lavfi: add xbr filter

[Michael Niedermayer]

On Sun, Nov 09, 2014 at 01:13:18AM +0100, Stefano Sabatini wrote:
> On date Sunday 2014-11-09 00:59:36 +0530, arwa arif encoded:
[...]
>
> > +#define pg_lbmask        0x00FEFEFE
> > +#define pg_red_blue_mask 0x00FF00FF
> > +#define pg_green_mask    0x0000FF00
> 
> pg stands for? Also usually macros and defines are UPCASED.

the names where taken from the reference code, so i suspect none of
us can know what pg stands for


[...]
> > +static uint32_t df(uint32_t x, uint32_t y, const uint32_t *r2y)
> > +{
> > +
> > +#define YMASK 0xff0000
> > +#define UMASK 0x00ff00
> > +#define VMASK 0x0000ff
> > +
> > +    uint32_t yuv1 = r2y[x & 0xffffff];
> > +    uint32_t yuv2 = r2y[y & 0xffffff];
> 
> Note: is the mask needed?

this depends on if AV_PIX_FMT_0RGB32 is guranteed to have the 0 byte
really 0. I would not bet on that, even if it works i suggest to leave
this masking in there somewhere

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141109/c734c362/attachment.asc>