[FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file

TOYAMA Shin-ichi shin1 at wmail.plala.or.jp
Tue Nov 11 15:41:53 CET 2014


Nicolas George wrote in <20141110140122.GA22517 at phare.normalesup.org>
>Thanks for the patch. See comments below.

O.K. I've finished to revise the patch.
Please see attached.

>The update for the documentation is missing.

Added short description to doc/decoders.texi.

>> +  if (strncmp(p, "ifo:", 4) == 0) {
>
>This can be discussed, but I would prefer having a separate -ifo_file
>option.

I agree. Separated to -use_ifo_palette option.

Hendrik Leppkes wrote in <CA+anqdwL+Q+y9vE_VGMBNAks3W8LBTaAzQETvJPEOQFSxWisCw at mail.gmail.com>
>We have conversion macros for those, see yuv_a_to_rgba at the beginning of
>the same file.
>In fact, if you just read all the YCbCr stuff into a fixed-size buffer
>first, you might even be able to use the same function for the entire
>conversion.

Thanks! Those macros worked fine in my function.

-- 
TOYAMA Shin-ichi mailto:shin1 at wmail.plala.or.jp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-New-option-for-obtaining-global-palette-from-.IFO-file.patch
Type: application/octet-stream
Size: 4381 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141111/f82a8beb/attachment.obj>


More information about the ffmpeg-devel mailing list