[FFmpeg-devel] [PATCH 3/9] lavf/ffm: store/restore private codec context

[Stefano Sabatini]

On date Wednesday 2014-11-12 09:09:43 +0100, Nicolas George encoded:
> Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit :
> > +static int ffm_write_header_codec_private_ctx(AVIOContext *pb, void *priv_data, int type)
> > +{
> > +    AVIOContext *tmp;
> > +    char *buf = NULL;
> > +
> > +    if (priv_data) {
> > +        if (avio_open_dyn_buf(&tmp) < 0)
> > +            return AVERROR(ENOMEM);
> 
> > +        av_opt_serialize(priv_data, AV_OPT_FLAG_ENCODING_PARAM | type, 1, &buf, '=', ',');
>                                                                           ^

> Unless I am mistaken, this is skip_default. What happens if the instance
> that reads the file does not have the same defaults as the instance that has
> written it? For example, what happens if ffmpeg feeding ffserver is not the
> same version as ffserver?

We should specify an FFM version, and abort in case it's not
compatible.
-- 
FFmpeg = Frenzy Fierce Mere Pitiless Epic Game