[FFmpeg-devel] [PATCH 2/2] x86/flacdsp: add SSE2 and AVX decorrelate functions

[James Almer]

On 13/11/14 11:59 AM, Michael Niedermayer wrote:
> On Mon, Nov 10, 2014 at 05:37:29PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Now also with indep8 (x86_64 only), and I'm pretty much done with these.
>>
>>  libavcodec/arm/flacdsp_init_arm.c |   2 +-
>>  libavcodec/flacdec.c              |   6 +-
>>  libavcodec/flacdsp.c              |   6 +-
>>  libavcodec/flacdsp.h              |   6 +-
>>  libavcodec/flacenc.c              |   2 +-
>>  libavcodec/x86/flacdsp.asm        | 254 ++++++++++++++++++++++++++++++++++++++
>>  libavcodec/x86/flacdsp_init.c     |  63 +++++++++-
>>  7 files changed, 327 insertions(+), 12 deletions(-)
> 
> should be ok, also fate tested on mingw

Pushed, thanks.

FATE doesn't currently cover samples other than stereo, so it's not enough to check 
this. I had to create multichannel 16 and 24 bits samples to test all cases.
I considered adding new tests for that, but the current tests use pcm reference files, 
and adding new multichannel ones would mean considerably increasing the fate suit in 
size.
Maybe the audiogen generated samples could be used instead, although they seem to be 
16bits only.