[FFmpeg-devel] [PATCH 2/2] avcodec/nellymoser: Use avpriv_float_dsp_alloc()

Michael Niedermayer michaelni at gmx.at
Fri Nov 14 20:38:39 CET 2014


On Fri, Nov 14, 2014 at 07:59:17PM +0100, Reimar Döffinger wrote:
> On Fri, Nov 14, 2014 at 02:39:46PM +0100, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/nellymoserdec.c |    9 ++++++---
> >  libavcodec/nellymoserenc.c |   17 +++++++++++------
> >  2 files changed, 17 insertions(+), 9 deletions(-)
> > 
> > diff --git a/libavcodec/nellymoserdec.c b/libavcodec/nellymoserdec.c
> > index ef16fd6..2d8a594 100644
> > --- a/libavcodec/nellymoserdec.c
> > +++ b/libavcodec/nellymoserdec.c
> > @@ -51,7 +51,7 @@ typedef struct NellyMoserDecodeContext {
> >      AVLFG           random_state;
> >      GetBitContext   gb;
> >      float           scale_bias;
> > -    AVFloatDSPContext fdsp;
> > +    AVFloatDSPContext *fdsp;
> 
> Why, and why only for Nellymoser?
> I could see it from an ABI compatibility standpoint, but wouldn't
> this be fairly pointless unless all other uses are changed as well?

it will be done for all uses after the API itself is pushed.
nelly was just an example and for ensuring the API is tested & works

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141114/f105587c/attachment.asc>


More information about the ffmpeg-devel mailing list