[FFmpeg-devel] [PATCH] libavformat/mxfdec.c: export source package uids and names as metadata

[Mark Reid]

On Fri, Nov 21, 2014 at 1:25 AM, Tomas Härdin <tomas.hardin at codemill.se>
wrote:

> On Tue, 2014-11-18 at 16:52 -0800, Mark Reid wrote:
> > ---
> >  libavformat/mxfdec.c | 74
> +++++++++++++++++++++++++++-------------------------
> >  1 file changed, 39 insertions(+), 35 deletions(-)
> >
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index fa0a2f4..8c13c24 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
>
> >  static int mxf_timestamp_to_str(uint64_t timestamp, char **str)
> >  {
> >      struct tm time = { 0 };
> > @@ -1969,7 +1973,7 @@ static const MXFMetadataReadTableEntry
> mxf_metadata_read_table[] = {
> >      { {
> 0x06,0x0e,0x2b,0x34,0x02,0x53,0x01,0x01,0x0d,0x01,0x01,0x01,0x01,0x01,0x30,0x00
> }, mxf_read_identification_metadata },
> >      { {
> 0x06,0x0e,0x2b,0x34,0x02,0x53,0x01,0x01,0x0d,0x01,0x01,0x01,0x01,0x01,0x18,0x00
> }, mxf_read_content_storage, 0, AnyType },
> >      { {
> 0x06,0x0e,0x2b,0x34,0x02,0x53,0x01,0x01,0x0d,0x01,0x01,0x01,0x01,0x01,0x37,0x00
> }, mxf_read_source_package, sizeof(MXFPackage), SourcePackage },
> > -    { {
> 0x06,0x0e,0x2b,0x34,0x02,0x53,0x01,0x01,0x0d,0x01,0x01,0x01,0x01,0x01,0x36,0x00
> }, mxf_read_material_package, sizeof(MXFPackage), MaterialPackage },
> > +    { {
> 0x06,0x0e,0x2b,0x34,0x02,0x53,0x01,0x01,0x0d,0x01,0x01,0x01,0x01,0x01,0x36,0x00
> }, mxf_read_source_package, sizeof(MXFPackage), MaterialPackage },
>
> Maybe rename mxf_read_source_package to mxf_read_package?
> Noticing that both functions are quite similar is a good catch :)
> The rest of the patch looks fine.
>
>
great, sounds good, I'll submit a v2 patch renaming mxf_read_source_package
-> mxf_read_package

/Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>