[FFmpeg-devel] [PATCH] lavu/opt: add const to av_opt_copy arg

Lukasz Marek lukasz.m.luki2 at gmail.com
Sun Nov 23 01:01:19 CET 2014


On 23.11.2014 00:58, Lukasz Marek wrote:
> Signed-off-by: Lukasz Marek <lukasz.m.luki2 at gmail.com>
> ---
>   libavutil/opt.c | 2 +-
>   libavutil/opt.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index 0546a37..47b1f0c 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1570,7 +1570,7 @@ static int opt_size(enum AVOptionType type)
>       return 0;
>   }
>
> -int av_opt_copy(void *dst, void *src)
> +int av_opt_copy(void *dst, FF_CONST_AVUTIL53 void *src)
>   {
>       const AVOption *o = NULL;
>       const AVClass *c;
> diff --git a/libavutil/opt.h b/libavutil/opt.h
> index 7338e78..6b6c996 100644
> --- a/libavutil/opt.h
> +++ b/libavutil/opt.h
> @@ -825,7 +825,7 @@ int av_opt_query_ranges(AVOptionRanges **, void *obj, const char *key, int flags
>    * @param src  Object to copy into
>    * @return 0 on success, negative on error
>    */
> -int av_opt_copy(void *dest, void *src);
> +int av_opt_copy(void *dest, FF_CONST_AVUTIL53 void *src);
>
>   /**
>    * Get a default list of allowed ranges for the given option.
>

I added FF_CONST_AVUTILS53 macro, but is this really needed? Cannot be 
just const?
I'm asking because I think it doesn't fix anything.
I guess is it API/ABI thing, but why?


More information about the ffmpeg-devel mailing list