[FFmpeg-devel] [PATCH] xface: Fix encoder crashes due to too small on-stack array.

Stefano Sabatini stefasab at gmail.com
Sun Nov 23 12:01:57 CET 2014


On date Sunday 2014-11-23 06:53:04 +0100, Reimar Döffinger encoded:
> On Sat, Nov 22, 2014 at 11:14:45PM +0100, Reimar Döffinger wrote:
> > Also add a FATE test.
> > 
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > ---
> >  libavcodec/xface.h             | 9 +++++----
> >  libavcodec/xfaceenc.c          | 3 +++
> >  libavformat/nut.c              | 1 +
> 
> I forgot this part:
> 
> >  const AVCodecTag ff_nut_video_tags[] = {
> > +    { AV_CODEC_ID_XFACE,            MKTAG('X', 'F', 'A', 'C') },
> 
> Is that ok to just do?

I noticed that, probably a separate commit would be better indeed.

This change should be approved by Michael (not sure if this requires
NUT specification updates).
-- 
FFmpeg = Fostering Free Mythic Pure Extensive Guru


More information about the ffmpeg-devel mailing list