[FFmpeg-devel] [PATCH v2] Fix undefined reference to xcb_shape_rectangles in xcbgrab.c

[Michael Niedermayer]

On Mon, Nov 24, 2014 at 02:00:05AM -0600, Boris Reisig wrote:
> Sorry, here's an update of my  patch that works with
> (--enable-libxcb-shape)  and without (--disable-libxcb-shape) now.
> Attached is v2 of the patch.
> 
> On 11/23/2014 5:13 PM, Michael Niedermayer wrote:
> >Hi
> >
> >On Sun, Nov 23, 2014 at 02:48:54PM -0600, Boris Reisig wrote:
> >>It seems when using the latest ffmpeg from master git, there's an
> >>incompatible change in the last few weeks that prevents libxcb-shape
> >>from being detected properly in ffmpeg so it wouldn't compile
> >>properly.  I have written a patch to fix the detection to make
> >>ffmpeg compile properly.
> >>
> >>
> >>Example if if failing to compile.
> >>
> >>INSTALL doc/libavcodec.3
> >>INSTALL doc/libavformat.3
> >>INSTALL doc/libavdevice.3
> >>INSTALL doc/libavfilter.3
> >>LD      ffmpeg_g
> >>libavdevice/libavdevice.a(xcbgrab.o): In function `xcbgrab_read_header':
> >>xcbgrab.c:(.text.unlikely+0x52c): undefined reference to
> >>`xcb_shape_rectangles'
> >>collect2: error: ld returned 1 exit status
> >>Makefile:122: recipe for target 'ffmpeg_g' failed
> >>make: *** [ffmpeg_g] Error 1
> >a quite similar patch was already posted, and i have the same question
> >as with that one, does this work with --disable-libxcb-shape ?
> >
> >Please someone confirm that it does work with --disable-libxcb-shape
> >or if not please adjust the patch so it does something appropriate
> >also carl has posted a untested alternative patch in the previous
> >thread "[FFmpeg-devel] [PATCH] libxcb-xhsape in configure"
> >i really would like to apply a fix for this but i need a bit feedback
> >on which is best and what works
> >
> >Thanks
> >
> >[...]
> >
> 

> # This fixes the latest ffmpeg not compiling the latest libxcb with shape support. Boris Reisig <voip at boris.ca>
> diff -uNr ffmpeg-2.4.3-original/configure ffmpeg-2.4.3/configure

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141124/91c63d8e/attachment.asc>