[FFmpeg-devel] [PATCH] lavu/imgutils: remove redundant and wrong check in av_image_fill_arrays

[Stefano Sabatini]

On date Thursday 2014-11-27 12:38:21 +0100, Michael Niedermayer encoded:
> On Thu, Nov 27, 2014 at 12:36:42PM +0100, Michael Niedermayer wrote:
> > On Thu, Nov 27, 2014 at 12:29:12PM +0100, Stefano Sabatini wrote:
> > > ---
> > >  libavutil/imgutils.c | 3 ---
> > >  1 file changed, 3 deletions(-)
> > 
> > LGTM
> 
> that is assuming its ok if the output arrays change on error, i think
> the function can change them in that case

I remember that assumption in legacy code (data pointers were set to
NULL in case of error), that was the reason for the double check, but
I couldn't find any instance requiring that condition, and that's not
documented so it's probably fine to remove the check.

Patch was already applied when I read your message.
-- 
FFmpeg = Fiendish & Fiendish Moronic Philosophical Exxagerate God