[FFmpeg-devel] *** GMX Spamverdacht *** Re: patch 1/4: libavcodec/ppc/pixblockdsp.c: fix get_pixels_altivec() and diff_pixels_altivec() for POWER LE

[Reimar Döffinger]

On 02.10.2014, at 03:38, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Sep 30, 2014 at 07:51:38PM +0200, Reimar Döffinger wrote:
>> On Tue, Sep 30, 2014 at 03:51:55PM +0800, rongyan wrote:
>>> Hi,
>>> I present 4 patches to fix bugs for POWER8 little endian.
>>> I will send 4 patches in 4 different email. This is the first.
>>> The fate test result after merge these 4 patches can be found on http://fate.ffmpeg.org/ by search "ibmcrl", also attached here to facilitate the review:
>>> 
>>> 
>>> ​
>>> The passed test cases increased from 1649/2169 to 1675/2174.
>> 
>> This one seems wrong.
>> I assume HAVE_VSX is a feature related define, which means it should
>> be possible to disable it without breaking anything.
>> If the altivec implementation is broken on little-endian,
>> the correct bug-fix is to disable it.
>> Then as a next step can a different optimized implementation be added.
> 
> you mean
> #if HAVE_VSX
> #elif HAVE_ALTIVEC && HAVE_BIGENDIAN
> ...
> #endif
> ?
> 
> if so this would also apply to the other patches probably and also to
> existing code in git though

Yes, I saw that its already done like that in a lot of places, which also should be changed.