[FFmpeg-devel] [PATCH 1/18] avcodec: remove obsolete FF_API_FAST_MALLOC cruft

[James Almer]

On 01/10/14 12:31 AM, James Almer wrote:
> On 01/10/14 12:18 AM, Michael Niedermayer wrote:
>> On Tue, Sep 30, 2014 at 11:57:14PM -0300, James Almer wrote:
>>> On 30/09/14 11:34 PM, Michael Niedermayer wrote:
>>>> On Mon, Sep 15, 2014 at 10:59:39PM +0200, Andreas Cadhalpun wrote:
>>>>> On 15.09.2014 22:03, Michael Niedermayer wrote:
>>>>>> On Mon, Sep 15, 2014 at 04:08:49PM -0300, James Almer wrote:
>>>>>>> On 15/09/14 6:07 AM, Michael Niedermayer wrote:
>>>>>>>> On Sun, Sep 14, 2014 at 10:46:03PM -0300, James Almer wrote:
>>>>>>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>>>>>>
>>>>>>>> about the patchset as a whole, not specifically this one
>>>>>>>>
>>>>>>>> we should check if theres any software left around that still uses
>>>>>>>> the symbols before removing the code completely and if so consider
>>>>>>>> to reintroduce them in a 2.4.1 while removing whats unused
>>>>>>>
>>>>>>> Pushed the three you reviewed since either no code depended on them, or in the
>>>>>>> OpenCL case it's an API that nobody has ever been able to use anyway.
>>>>>>>
>>>>>>> I'm not exactly interested in looking around to see if any of this deprecated
>>>>>>> stuff is still used. And IMO reintroducing them in a point release is quite ugly.
>>>>>>> An exception could be FF_API_DRAWTEXT_OLD_TIMELINE since as Clément pointed in
>>>>>>> another email might be needed to remain compatible with libav.
>>>>>>
>>>>>> probably you only have to wait, as i suspect andreas (in CC) will
>>>>>> test building all dependant packages in debian against 2.4
>>>>>
>>>>> You're right that I'm currently rebuilding those against 2.4, but I
>>>>> don't expect any problems there, since I already have rebuilt them
>>>>> against a git snapshot about two weeks ago and didn't notice
>>>>> anything problematic.
>>>>
>>>> any news ? can these be applied ?
>>>
>>> Debian packages are all meant to work with libav 9 or 11 api, and all this deprecated 
>>> code removed in 2.4 was ffmpeg exclusive, so it's unlikely they used any of it.
>>> Also, 2.4 has been out for two weeks and nobody complained about their applications 
>>> breaking because these are no longer available.
>>>
>>> We could wait a bit more in any case. The entire patchset is just dead code removal.
>>
>> ok, just dont forget about them, i wont keep track of them anymore
>> too much stuff to keep track off ....
> 
> I'll apply them this weekend, then.

Patchset applied, except for "[PATCH 17/18] avfilter: remove obsolete FF_API_DRAWTEXT_OLD_TIMELINE cruft" 
as we may need to reintroduce that functionality to remain compatible with libav.