[FFmpeg-devel] [PATCH] avformat/movenc: add EAC3 muxing support.

[Benoit Fouet]

Hi,

----- Mail original -----
> On Fri, Oct 10, 2014 at 10:28:51AM +0200, Benoit Fouet wrote:
> > Hi,
> > 

[...]

> > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > index bfee866..f592c9c 100644
> > --- a/libavformat/movenc.c
> > +++ b/libavformat/movenc.c
> > @@ -31,6 +31,7 @@
> >  #include "avio.h"
> >  #include "isom.h"
> >  #include "avc.h"
> > +#include "libavcodec/ac3_parser.h"
> >  #include "libavcodec/get_bits.h"
> >  #include "libavcodec/put_bits.h"
> >  #include "libavcodec/vc1_common.h"
> > @@ -292,6 +293,182 @@ static int mov_write_ac3_tag(AVIOContext *pb,
> > MOVTrack *track)
> >      return 11;
> >  }
> >  
> > +struct eac3_info {
> > +    uint8_t ec3_done;
> > +
> > +    /* Layout of the EC3SpecificBox */
> 
> > +    /* maximum bitrate */
> > +    uint16_t data_rate;
> [...]
> > +    info->data_rate = FFMAX(info->data_rate, hdr->bit_rate);
> [...]
> > +    put_bits(&pbc, 13, info->data_rate);
> 
> something is wrong here, a bit_rate of 128000 (128k) wont fit in a
> uint16_t nor in 13 bits
> 

Yeah, this should be the bitrate in kbits/s, fixed, thanks.

-- 
Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-movenc-add-EAC3-muxing-support.patch
Type: text/x-patch
Size: 11213 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141010/a5648721/attachment.bin>