[FFmpeg-devel] [PATCH] mov.c: read fragment start dts from fragmented mp4

[Mika Raento]

On 11 October 2014 16:41, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Mika Raento <mikie <at> iki.fi> writes:
>
>> +    if (ret < 0)
>> +        av_log(c->fc, AV_LOG_ERROR,
>> +               "failed to seek back after looking for mfra\n");
>> +    else
>> +        ret = 0;
>
> If you resubmit please consider making this:
> if (ret < 0) {
>   avl_log();
> } else {
>   ret = 0;
> }
>
> This makes future patches much easier to read and costs only
> a line.

I can definitely do that. Somehow I'd gotten the impression that the
opposite was preferred, and indeed mov.c tends not to have those
braces. Has the convention changed?

>
> Thank you, Carl Eugen

    Mika

>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel