[FFmpeg-devel] [PATCH 7/7] avcodec/ass: add FFmpeg signature

[Timothy Gu]

On Sat, Oct 11, 2014 at 7:05 PM, James Almer <jamrial at gmail.com> wrote:
> On 11/10/14 10:58 PM, Timothy Gu wrote:

>>
>>
>> I think you misread it: the colon is after the
>> AV_STRINGIFY(LIBAVCODEC_VERSION).
>>
>>
>
> (avctx->flags & CODEC_FLAG_BITEXACT) ? "; Script generated by FFmpeg/Lavc" AV_STRINGIFY(LIBAVCODEC_VERSION) "\r\n" : ""
>
> Meaning
>
> if (avctx->flags & CODEC_FLAG_BITEXACT)
>     "; Script generated by FFmpeg/Lavc" AV_STRINGIFY(LIBAVCODEC_VERSION) "\r\n"
> else

Yes. In your original main you said:

>>> I think you wanted to do the inverse here. You can't use version macros
>>> when bitexact
>>> is requested.

Obviously the AV_STRINGIFY(LIBAVCODEC_VERSION) is not in the if{}
block, thus it is not used when bitexact is requested.

Timothy