[FFmpeg-devel] [PATCH] avformat/id3v2: only use syncsafe for extended header size.

[Benoit Fouet]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
Hi,

Le 14/10/2014 04:37, Michael Niedermayer a écrit :
> On Mon, Oct 13, 2014 at 03:53:32PM +0200, Benoit Fouet wrote:
>> Fixes ticket #4003
>> ---
>>  libavformat/id3v2.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> this breaks fate-exif-image-embedded

And for a reason... I've read some more, and actually, the actual
behaviour is the correct one.
There are encoders writing 2.4 tags like the 2.3 ones, though.
Another approach could be to check the next tag to see if the size is
correct, and if not, fallback to 2.3 sizes for 2.4 tags.
Should I try that?

- -- 
Ben

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)
 
iEYEARECAAYFAlQ80wQACgkQACOuHimFScgrlgCeIYCWCJBVF20wKF3l3U4eCbep
gNsAn1UTw+fX3b0f+FRCLuPjMLf1kfcZ
=NJvc
-----END PGP SIGNATURE-----