[FFmpeg-devel] Patch for Cast128 algorithm implementation

[supraja reddy]

Updated the patch .
Please let me know if there are any other changes needed .

Thanks ,

Supraja

On Thu, Oct 16, 2014 at 1:37 PM, Giorgio Vazzana <mywing81 at gmail.com> wrote:

> Hi,
>
> 2014-10-16 5:32 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> > On Thu, Oct 16, 2014 at 03:25:42AM +0530, supraja reddy wrote:
> >> Extremely sorry for resending the patch . There was a trailing
> whitespace
> >> which I hadn't corrected .
> >> All the changes are done .
> >> Please let me if any changes needed further .
>
> > also a test that enciphers and deciphers a larger amount of random
> > data could be added
>
> The RFC defines a "Full Maintenance Test",
>
> http://tools.ietf.org/html/rfc2144#appendix-B.2
>
> it should probably be added (easy: just a few lines of code).
>
> >
> >
> >> +    return err;
> >> +}
> >> +#endif
> >> diff --git a/libavutil/cast5.h b/libavutil/cast5.h
> >> new file mode 100644
> >> index 0000000..d151031
> >> --- /dev/null
> >> +++ b/libavutil/cast5.h
> >> @@ -0,0 +1,60 @@
> >> +/*
> >> + * An implementation of the CAST128 algorithm as mentioned in RFC2144
> >> + * Copyright (c) 2014 Supraja Meedinti
> >> + *
> >> + * This file is part of FFmpeg.
> >> + *
> >> + * FFmpeg is free software; you can redistribute it and/or
> >> + * modify it under the terms of the GNU Lesser General Public
> >> + * License as published by the Free Software Foundation; either
> >> + * version 2.1 of the License, or (at your option) any later version.
> >> + *
> >> + * FFmpeg is distributed in the hope that it will be useful,
> >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> >> + * Lesser General Public License for more details.
> >> + *
> >> + * You should have received a copy of the GNU Lesser General Public
> >> + * License along with FFmpeg; if not, write to the Free Software
> >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301 USA
> >> + */
> >> +
> >> +#ifndef AVUTIL_CAST5_H
> >> +#define AVUTIL_CAST5_H
> >> +
> >> +#include <stdint.h>
> >> +
>
> >> +#include "attributes.h"
> >> +#include "version.h"
>
> I think version.h is not needed and you can move attributes.h to cast5.c
>
> No more comments from me, apart from: well done! Another round of
> revision and hopefully we'll soon be able to apply the patch :)
>
> Giorgio
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-CAST128-symmetric-block-cipher-to-libavutil-n-nO.patch
Type: text/x-patch
Size: 40222 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141016/ddbb2594/attachment.bin>