[FFmpeg-devel] [PATCH] matroskadec: execute seekheads recursively

[wm4]

On Fri, 17 Oct 2014 01:55:35 -0500
Rodger Combs <rodger.combs at gmail.com> wrote:

> 
> > On Oct 17, 2014, at 01:52, Rodger Combs <rodger.combs at gmail.com> wrote:
> > 
> > 
> >> On Oct 17, 2014, at 01:16, Rodger Combs <rodger.combs at gmail.com <mailto:rodger.combs at gmail.com>> wrote:
> >> 
> >> This fixes https://trac.ffmpeg.org/ticket/3934 <https://trac.ffmpeg.org/ticket/3934>, but I'm not sure if there was a good reason for this to be here to begin with. Perhaps a protection against infinite recursion (though I believe EBML_MAX_DEPTH serves that purpose to some degree)?
> >> <0001-matroskadec-execute-seekheads-recursively.patch>
> > 
> > Evidently either I or my mail client screwed up and the patch didn't get attached. Whoops.
> > <0001-matroskadec-execute-seekheads-recursively.patch>
> > Let's try that again...
> 
> Welp, apparently my email client's borked badly in some way. Here's a gist link instead: https://gist.github.com/08f111e72b8b5ddba078
> 

Yes, seekheads can reference other seekheads. IMO it should perhaps
keep a list of elements to read (and which have already been read),
which includes the seakhead. Since it'd be a list, it'd be safe against
recursion.