[FFmpeg-devel] [PATCH] add both single and mutiple frame detection metadata in vf_idet

[Kevin Mitchell]

I've bumped the minor (not micro) version. I hope that's what was
wanted. I also added the requested documentation of the metadata
fields. Sorry I guess I was following the bad convention that most of
the filter metadata isn't documented.

On Sun, Oct 19, 2014 at 2:38 PM, Clément Bœsch <u at pkh.me> wrote:
> On Sun, Oct 19, 2014 at 02:34:40PM -0700, Kevin Mitchell wrote:
>> Doh. Not having a good day. Use consistent metadata tags.
>>
>> On Sun, Oct 19, 2014 at 1:37 PM, Kevin Mitchell <kevmitch at gmail.com> wrote:
>> > Thanks for the quick merge. Unfortunately, i realized i only added the
>> > metadata for single frame detection. This patch adds both single and
>> > multiple frame detection.
>
>> From 36235c82dee67b568aacee919f5b357102c0e2f6 Mon Sep 17 00:00:00 2001
>> From: Kevin Mitchell <kevmitch at gmail.com>
>> Date: Sun, 19 Oct 2014 13:32:56 -0700
>> Subject: [PATCH] avfilter/vf_idet: add both multiple and single frame
>>  detection metadata
>>
>> ---
>>  libavfilter/vf_idet.c | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavfilter/vf_idet.c b/libavfilter/vf_idet.c
>> index ebbc7d2..339f4a6 100644
>> --- a/libavfilter/vf_idet.c
>> +++ b/libavfilter/vf_idet.c
>> @@ -178,10 +178,15 @@ static int filter_frame(AVFilterLink *link, AVFrame *picref)
>>
>>      filter(ctx);
>>
>> -    av_dict_set_int(metadata, "lavfi.idet.tff", idet->prestat[TFF], 0);
>> -    av_dict_set_int(metadata, "lavfi.idet.bff", idet->prestat[BFF], 0);
>> -    av_dict_set_int(metadata, "lavfi.idet.progressive", idet->prestat[PROGRESSIVE], 0);
>> -    av_dict_set_int(metadata, "lavfi.idet.undetermined", idet->prestat[UNDETERMINED], 0);
>> +    av_dict_set_int(metadata, "lavfi.idet.single.tff", idet->prestat[TFF], 0);
>> +    av_dict_set_int(metadata, "lavfi.idet.single.bff", idet->prestat[BFF], 0);
>> +    av_dict_set_int(metadata, "lavfi.idet.single.progressive", idet->prestat[PROGRESSIVE], 0);
>> +    av_dict_set_int(metadata, "lavfi.idet.single.undetermined", idet->prestat[UNDETERMINED], 0);
>> +
>> +    av_dict_set_int(metadata, "lavfi.idet.multiple.tff", idet->poststat[TFF], 0);
>> +    av_dict_set_int(metadata, "lavfi.idet.multiple.bff", idet->poststat[BFF], 0);
>> +    av_dict_set_int(metadata, "lavfi.idet.multiple.progressive", idet->poststat[PROGRESSIVE], 0);
>> +    av_dict_set_int(metadata, "lavfi.idet.multiple.undetermined", idet->poststat[UNDETERMINED], 0);
>>
>
> Can you bump minor avfilter version this time?
>
> And complete documentation, please.
>
> [...]
>
> --
> Clément B.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avfilter-vf_idet-add-both-multiple-and-single-frame-.patch
Type: text/x-patch
Size: 3565 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141019/5757e7b9/attachment.bin>