[FFmpeg-devel] [PATCH] lavfi: add xbr filter

[Nicolas George]

Le quartidi 4 brumaire, an CCXXIII, arwa arif a écrit :
> > please post a new patch instead of a patch on top of a previous
> > patch
>  libavfilter/vf_xbr.c |  303 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 303 insertions(+)
>  create mode 100644 libavfilter/vf_xbr.c

This patch does not contain the changes to Makefile and allfilters.c, so I
believe you still have a bit of tweaking to do with Git.

If you used a branch (that is widely advisable), you should be able to type
this:

git log --stat master..

Then you should see a single commit, yours, with changes to Makefile,
allfilters.c and all other common files you needed to changes, and of course
the new file(s).

(If you have stand-alone changes, such as moving code into a shared function
to use in your actual patch, then it should go in a separate commit. But it
does not seem to apply here.)

Also, I suspect you forgot to add the documentation for the filter in
doc/filters.texi. A few words are enough, but at the very least let people
know what it does, because xbr looks like just three random letters -- not
your fault of course.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141025/407d990e/attachment.asc>