[FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

[Carl Eugen Hoyos]

On Tuesday 28 October 2014 03:36:05 pm Thomas Mundt wrote:
> -    mxf_write_cdci_common(s, st, mxf_mpegvideo_descriptor_key, 8+5);
> -    // bit rate
> -    mxf_write_local_tag(pb, 4, 0x8000);
> -    avio_wb32(pb, sc->video_bit_rate);
> -
> -    // profile and level
> -    mxf_write_local_tag(pb, 1, 0x8007);
> -    if (!st->codec->profile)
> -        profile_and_level |= 0x80; // escape bit
> -    avio_w8(pb, profile_and_level);

It makes reviewing your patch much easier if you do not re-indent 
these lines: Just leave them unchanged, consider sending a 
followup to fix the indentation.
(Or leave it to the committer.)

> +    }
> +    else
> +        mxf_write_cdci_common(s, st, mxf_mpegvideo_descriptor_key, 0);

While here, please make this:
    } else {
        mxf_write_cdci_common(=;
    }
to follow the preferred coding style.

And please consider to commit your patch locally, create a 
patchfile with "git format-patch HEAD^" and attach it to your 
mail.

Thank you, Carl Eugen