[FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

[Michael Niedermayer]

On Wed, Sep 03, 2014 at 04:24:29AM +0200, Michael Niedermayer wrote:
> On Wed, Sep 03, 2014 at 02:37:48AM +0100, Kieran Kunhya wrote:
> > On 3 September 2014 01:40, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > On Wed, Sep 03, 2014 at 12:59:53AM +0100, Kieran Kunhya wrote:
> > >> Patch not sent to ML so couldn't review:
> > >>
> > >> Why have you only changed the code to favour DESC_types and not other types?
> > >
> > > because thats what was needed to fix Ticket3766, which was what the
> > > commit tried to do.
> > >
> > > We might want to change others too, ideally would be if we had actual
> > > testcases for them that need it. So the changes can be tested.
> > >
> > > Do you have some testcases ?
> > 
> > In general you should not be probing if there are descriptors because
> > the descriptors are designed to make the codec detection unambiguous.
> 
> yes
> 
> 
> > 
> > How do testcases for stream detection even work in FATE?
> 
> see tests/fate/probe.mak

oops, thats just container detection, i meant
tests/fate/ffprobe.mak

something similar i suspect could be used but i didnt try it


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140903/98c60101/attachment.asc>