[FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

[Clément Bœsch]

On Sun, Aug 31, 2014 at 02:35:40PM +0200, Andreas Cadhalpun wrote:
> On 28.08.2014 20:06, Nicolas George wrote:
> >Le primidi 11 fructidor, an CCXXII, Andreas Cadhalpun a écrit :
> >>I like this colour of the shed. ;)
> >>  * move lena.pnm to the FATE samples
> >>  * add e.g. mona_lisa.pnm and duplicate the vsynth2 tests (as vsynth4?)
> >>
> >>Has someone a problem with this solution?
> >
> >I find it very good.
> >
> >Just a small nitpick: does the image have to be 256×256? If not, I suggest
> >to make mona_lisa.pnm 256×384 or 192×288, to avoid cropping the original.
> 
> Yes, 256×384 fits better.
> Attached is a patch on top of the one removing tests/lena.pnm, adding
> tests/mona_lisa.pnm and vsynth4 tests.
> 
> Best regards,
> Andreas

Duplicate all the tests? Yeah please no, that's a hell to maintain.

lena.pnm can be moved to the FATE samples, and replaced in the repo by
something else.

The question is still by what we replace it. This can be the mona lisa but
the reason of the presence of lena.pnm is that it's extremely famous in
the image processing world, and so we should replace it with something
similar. Typically, mandrill.bmp could be a good candidate:
https://encrypted.google.com/search?tbm=isch&q=mandrill.bmp&tbs=imgo:1

...but I don't know the license either.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140903/69dee880/attachment.asc>