[FFmpeg-devel] patch for x32 for libpostproc

[Michael Niedermayer]

On Thu, Sep 04, 2014 at 07:42:00PM -0400, Reinhard Tartler wrote:
> On Thu, Sep 4, 2014 at 7:27 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Hi Reinhard
> >
> > On Wed, Sep 03, 2014 at 11:33:48PM -0400, Reinhard Tartler wrote:
> >> On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Wed, Sep 03, 2014 at 08:22:43PM -0400, Reinhard Tartler wrote:
> >> >> On Wed, Sep 3, 2014 at 9:39 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> > On Tue, Sep 02, 2014 at 10:06:10PM +0000, Thorsten Glaser wrote:
> >> >> >> Hi,
> >> >> >>
> >> >> >> as discussed in IRC, I was trying to minimal-invasively port
> >> >> >> libpostproc (the Debian source package) to x32¹. I could not
> >> >> >> test it (for lack of a stand-alone test program) yet, but at
> >> >> >> least I got it to build.
> >> >> >
> >> >> > you could try to test by buiding ffmpeg as a whole but disable asm
> >> >> > everywhere except libpostproc
> >> >> > that might allow "easy" testing though fate or ffmpeg with libavfilter
> >> >>
> >> >> Is http://git.videolan.org/?p=libpostproc.git still maintained?
> >> >
> >> > AFAIK, no, it seems the last commit is 2 years ago
> >> >
> >> >
> >> >>
> >> >> The Debian package tracks that repository, and ideally we could
> >> >> collect the postproc patches there.
> >> >
> >> > libpostproc was and is maintained in
> >> > git://source.ffmpeg.org/ffmpeg.git
> >>
> >> So the promise given in
> >> https://lists.libav.org/pipermail/libav-devel/2012-February/020712.html
> >> doesn't hold anymore?
> >
> > Can you be a bit more specific ? what "promise" by whom exactly do
> > you speak of ?
> >
> 
> The promise of having a maintained stand-alone libpostproc.
> 
> >>
> >> Any chance to make you reconsider reviving the standalone libpostproc.git?
> >
> > From what i remember there where some problems with that repository
> > so actually maintaining it would probably imply first recreating it
> >
> > for example try to build a old revission:
> >
> > git checkout a792a836e3d9ef6f1f311604b38095e587282ca7
> >     (this is libpostproc/master~20 ATM)
> > ./configure
> > -bash: ./configure: No such file or directory
> >
> > this is a problem for anyone maintaining the code as for example
> > git bisect
> > would not be usable at all
> >
> > or if you do a git show
> > commit a792a836e3d9ef6f1f311604b38095e587282ca7
> > Merge: 1d261c2 7f1c286 7391383 8f2dfd0 8cf4ef5 59d8d9c
> >
> > Its a commit with 6 ancestors, no commit in FFmpeg or Libav has 6
> > ancestors
> >
> > So really, if someone wants to maintain or use libpostproc.git, first
> > these things need to be fixed
> >
> > but i dont understand why you dont just take libpostproc
> > from where its developed, tested and used ?
> >
> > but if it helps i guess we could copy the libpostproc from FFmpeg
> > over the one in libpostproc.git (which is what reimar suggested)
> > libpostproc.git was only intended to be a copy of FFmpeg with libs
> > other than libpostproc removed anyway.
> >
> > Would this help you ?
> 
> At the end of the day, I need a source tarball that contains
> maintained sources of a stand-alone libpostproc. I don't care too much
> how it is created, as long as it doesn't result in code-duplication
> with existing sources in Debian.

would it work if libpostproc could be build and installed
standalone from ffmpeg git / ffmpeg release tarballs?

i havent really investigated it but it seems with the 2 line patch
below one can achive that with
./configure --enable-gpl --disable-all --enable-shared --enable-postproc  && make

(it also would need changing #includes "..." to <...> to use system
installed libavutil headers)

this seems a easier path than maintaining libpostproc.git if it
would work for debian, if not iam sure we will find another solution
like updating libpostproc.git.


diff --git a/Makefile b/Makefile
index 57f6a91..63423bf 100644
--- a/Makefile
+++ b/Makefile
@@ -48,7 +48,7 @@ FFLIBS-$(CONFIG_POSTPROC)   += postproc
 FFLIBS-$(CONFIG_SWRESAMPLE) += swresample
 FFLIBS-$(CONFIG_SWSCALE)    += swscale

-FFLIBS := avutil
+FFLIBS-$(CONFIG_AVUTIL)     += avutil

 DATA_FILES := $(wildcard $(SRC_PATH)/presets/*.ffpreset) $(SRC_PATH)/doc/ffprobe.xsd
 EXAMPLES_FILES := $(wildcard $(SRC_PATH)/doc/examples/*.c) $(SRC_PATH)/doc/examples/Makefile $(SRC_PATH)/doc/examples/README
diff --git a/configure b/configure
index 7de07c3..7a3764f 100755
--- a/configure
+++ b/configure
@@ -2614,7 +2614,7 @@ avdevice_deps="avformat avcodec avutil"
 avfilter_deps="avutil"
 avformat_deps="avcodec avutil"
 avresample_deps="avutil"
-postproc_deps="avutil gpl"
+postproc_deps="gpl"
 swresample_deps="avutil"
 swscale_deps="avutil"



[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140905/767c0af3/attachment.asc>