[FFmpeg-devel] [PATCH]Set H264 bitrate

[Michael Niedermayer]

On Tue, Aug 19, 2014 at 08:35:29AM +0200, Reimar Döffinger wrote:
> On 19.08.2014, at 02:24, Kieran Kunhya <kierank at obe.tv> wrote:
> > On 19 August 2014 00:32, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> >> Hi!
> >> 
> >> Attached patch from MIKEH / Elemental is apparently meant to implement
> >> setting h264 bitrate. It makes no difference for the sample from ticket
> >> #3392.
> > 
> > This patch is nonsensical unfortunately.
> 
> Could you expand on that?
> The only obvious issue I see is that bit_rate_value should be summed up instead of using only the last value.
> I suspect that is just a typo though.

independant of any sense or lack thereof
it produces a wildly wrong bitrate for
fate-suite//h264/interlaced_crop.mp4
(which is the only file from the fate suite for which the code
triggers it seems)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140905/478876bd/attachment.asc>