[FFmpeg-devel] patch for x32 for libpostproc

[Reinhard Tartler]

On Sun, Sep 7, 2014 at 5:30 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Sep 05, 2014 at 08:18:57AM +0200, Reimar Döffinger wrote:
>> On 05.09.2014, at 03:46, Reinhard Tartler <siretart at gmail.com> wrote:
>> > On Thu, Sep 4, 2014 at 9:32 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >>> At the end of the day, I need a source tarball that contains
>> >>> maintained sources of a stand-alone libpostproc. I don't care too much
>> >>> how it is created, as long as it doesn't result in code-duplication
>> >>> with existing sources in Debian.
>> >>
>> >> would it work if libpostproc could be build and installed
>> >> standalone from ffmpeg git / ffmpeg release tarballs?
>> >
>> > That would be exactly the code-duplication I referred to in the text
>> > you've quoted.
>>
>> Combined with a release script doing rm of libav*?
>> I think the problem is that libpostproc just isn't a viable stand-alone program, mostly due to complete lack of stand-alone testability not to mention test infrastructure.
>> Keeping the separate git up-to-date certainly is an option but involves extra effort (though a lot less than making libpostproc testable stand-alone).
>> I don't see a good way to split the libraries into separate repositories that does not involve either at least maintaining configure in each or seriously harming bisecting/regression testing.
>> Release scripts that generate multiple tarballs seems more realistic than splitting the repository, in case that sounds like helpful to anyone...
>
> Heres a proof of concept updated libpostproc
>
> https://github.com/michaelni/FFmpeg/tree/separated_libpostproc
>
> this is simply a clone of ffmpeg with everything unneeded
> droped and the build system from the libpostproc repository
> it builds successfully but is completely untested beyond that
>
> It seems the old buildsystem lacks HAVE_MMX*_INLINE support, this
> would need to be added, as well as updating README and all that as
> well as testing

That repo looks promising. However, the README and installations
instructions still refer to FFmpeg which seems rather confusing to me.
Also, the licensing needs to be clarified. AFAIUI, libpostproc is GPL
only, so adding a LGPL license is also confusing at best.

> also the differences in aboves repo could possibly be used to
> construct a script to create a split out libpostproc for debian
> if thats whats wanted.

Debian already does ship a split out libpostproc. I'm happy to upgrade
it to some newer version if a tarball appeared.

May I ask out of curiosity, what in FFmpeg actually uses libpostproc
other than than libavfilter/vf_pp.c? You said that you prefer to
maintain libpostproc inside FFmpeg because that way you can apply the
FFmpeg test system on it. I wonder what automated tests cover code in
libpostproc?

-- 
regards,
    Reinhard