[FFmpeg-devel] [PATCH]Add a closing CRLF to Webm-manifest files
Nicolas George
george at nsup.org
Fri Sep 12 08:52:03 CEST 2014
Le sextidi 26 fructidor, an CCXXII, Carl Eugen Hoyos a écrit :
> Attached patch fixes fate-webm-dash-manifest on aix.
> I cannot reproduce the problem on other systems and I
> don't know if the patch is correct.
I do not know that protocol, but adding a final newline at the end of an XML
file seems like the right thing to do.
> Subject: Re: [FFmpeg-devel] [PATCH]Add a closing CRLF to Webm-manifest files
> + avio_printf(s->pb, "</MPD>\n");
Small nit on the commit message: \n is just LF, CRLF would be \r\n. Just LF
should be fine with XML, especially if the rest of the file is already like
that.
Regards,
--
Nicolas George
More information about the ffmpeg-devel
mailing list