[FFmpeg-devel] [PATCH] Adds decode support for formats other than 420

Michael Niedermayer michaelni at gmx.at
Sat Sep 13 01:24:37 CEST 2014


On Fri, Sep 12, 2014 at 04:07:16PM -0700, Deb Mukherjee wrote:
> Handles decoding of new VP9 profiles 1-3 with different color sampling
> and bit-depths.
> 
> For high bitdepth (profiles 2 and 3) support, we currently need to link
> with the highbitdepth branch of libvpx with --enable-experimental
> and --enable-vp9-high config options on. But eventually this branch will
> be merged into master, whereafter to enable high bitdepth
> support you will need to link with libvpx with configure option
> --enable-vp9-highbitdepth on.
> ---

[...]

> @@ -104,7 +162,7 @@ static int vp8_decode(AVCodecContext *avctx,
>      return avpkt->size;
>  }
>  
> -static av_cold int vp8_free(AVCodecContext *avctx)
> +static av_cold int vpx_free(AVCodecContext *avctx)
>  {
>      VP8Context *ctx = avctx->priv_data;
>      vpx_codec_destroy(&ctx->decoder);
> @@ -124,8 +182,8 @@ AVCodec ff_libvpx_vp8_decoder = {
>      .id             = AV_CODEC_ID_VP8,
>      .priv_data_size = sizeof(VP8Context),
>      .init           = vp8_init,
> -    .close          = vp8_free,
> -    .decode         = vp8_decode,
> +    .close          = vpx_free,
> +    .decode         = vpx_decode,
>      .capabilities   = CODEC_CAP_AUTO_THREADS | CODEC_CAP_DR1,
>  };
>  #endif /* CONFIG_LIBVPX_VP8_DECODER */
> @@ -143,8 +201,8 @@ AVCodec ff_libvpx_vp9_decoder = {
>      .id             = AV_CODEC_ID_VP9,
>      .priv_data_size = sizeof(VP8Context),
>      .init           = vp9_init,
> -    .close          = vp8_free,
> -    .decode         = vp8_decode,
> +    .close          = vpx_free,
> +    .decode         = vpx_decode,
>      .capabilities   = CODEC_CAP_AUTO_THREADS | CODEC_CAP_DR1,
>      .init_static_data = ff_vp9_init_static,
>  };

renaming functions should be in a seperate patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140913/1dd969e5/attachment.asc>


More information about the ffmpeg-devel mailing list