[FFmpeg-devel] [PATCH] hlsenc: single_file, support HLS ver 4 byteranges

[Michael Niedermayer]

On Mon, Sep 15, 2014 at 06:34:44AM +0000, Raento Mika wrote:
> On 15/09/14 01:50, "Michael Niedermayer" <michaelni at gmx.at> wrote:
> 
> >On Sun, Sep 14, 2014 at 03:37:00PM +0300, Mika Raento wrote:
[...]
> >> @@ -289,17 +314,27 @@ static int hls_write_packet(AVFormatContext *s,
> >>AVPacket *pkt)
> >>  
> >>      if (can_split && av_compare_ts(pkt->pts - hls->start_pts,
> >>st->time_base,
> >>                                     end_pts, AV_TIME_BASE_Q) >= 0) {
> >> -        ret = hls_append_segment(hls, hls->duration);
> >> +        av_write_frame(oc, NULL); /* Flush any buffered data */
> >> +
> >> +        hls->size = hls->avf->pb->pos - hls->start_pos;
> >
> >is it intended to access pos directly instead of using avio_tell() ?


> >
> >
> >> +        int64_t start_pos = hls->avf->pb->pos;
> >
> >this mixes declarations and statements, some compilers dislike that

did you miss the 2 comments above ?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140915/63ccaec0/attachment.asc>