[FFmpeg-devel] [WIP] lavfi: port mp/eq to a regular filter

[James Darnley]

On 2014-09-15 02:03, Timothy Gu wrote:
> On Sep 14, 2014 3:46 PM, "James Darnley" <james.darnley at gmail.com> wrote:
>>
>> ---
>>
>> Still a couple of things on the todo list (see the top of the new file)
> but I
>> thought I would send the basics along for people to nit pick.
>>
>>  configure                |   1 +
>>  libavfilter/Makefile     |   1 +
>>  libavfilter/allfilters.c |   1 +
>>  libavfilter/vf_eq.c      | 157
> +++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 160 insertions(+)
>>  create mode 100644 libavfilter/vf_eq.c
> 
> [...]
> 
>> +#define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM
>> +static const AVOption eq_options[] = {
>> +    { "brightness", "", OFFSET(brightness), AV_OPT_TYPE_INT, {.i64 = 0}, -100, 100, FLAGS },
>> +    { "contrast",   "", OFFSET(contrast),   AV_OPT_TYPE_INT, {.i64 = 0}, -100, 100, FLAGS },
>> +    { NULL }
>> +};
> 
> Can vf_hue be improved to support changing contrast instead of writing a
> new filter just for that?

I do not know.  Clement asked (some time ago) for someone to look at
porting eq and eq2 and I volunteered.

I also seem to recall a discussion about dropping the remains of
libmpcodecs which didn't happen because people pointed out that (at
least) these two were still being used.

That thread might have been "[RFC] removing libmpcodecs for reuniting
purposes".


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140915/49c22455/attachment.asc>