[FFmpeg-devel] [PATCH] configure: disallow OpenCL with shared libs

[Michael Niedermayer]

On Thu, Aug 28, 2014 at 12:14:48AM -0300, James Almer wrote:
> On 27/08/14 11:53 PM, Wei Gao wrote:
> > 2014-08-13 9:45 GMT+08:00 Timothy Gu <timothygu99 at gmail.com>:
> > 
> >> On Aug 12, 2014 6:43 PM, "highgod0401" <highgod0401 at gmail.com> wrote:
> >>
> >>> Hi
> >>>
> >>> Warning is OK for me.
> >>
> >> Do you plan to change the API?
> >>
> > 
> > Hi
> > 
> > Sorry for the late reply, could you tell me more details?  How to change
> > it? I will change it according your suggestion.
> > 
> > Thanks
> > Best regards
> 
> It was more a question to know if there were any plans to change the API in 
> the short term. That way we'll know if the API should be considered not stable, 
> and thus disabled on shared builds.
> 
> Nonetheless, I'll take the chance to raise an issue: libavutil/opencl.h is 
> including "config.h", a header that's not installed, to check for HAVE_CL_CL_H.
> This is broken, meaning that nothing has been able to use the OpenCL API outside 
> of the couple libavfilter filters you modified.
> 
> I suggest using libavutil/avconfig.h instead, a generated and installed header, 
> but there may be a better/cleaner way.

CCing wei

please fix the config.h include stuff
also please decide if the API is experimental or not
if its experimental it MUST be clearly shown to be in the configure
help so that users know that they enable experimental API when
specifying --enable-opencl
If its not experimental then the API can only be changed in ways that
maintain API & ABI compatibility.

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140918/850708b8/attachment.asc>