[FFmpeg-devel] [PATCH 1/1] Fix compile error on arm4/arm5 platform

[Michael Niedermayer]

On Tue, Sep 23, 2014 at 09:31:39PM +0200, Michael Niedermayer wrote:
> On Tue, Sep 23, 2014 at 08:10:03PM +0200, Bernd Kuhls wrote:
> > Since these commits
> > http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=adf8227cf4e7b4fccb2ad88e1e09b6dc00dd00ed
> > http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=db7f1c7c5a1d37e7f4da64a79a97bea1c4b6e9f8
> > 
> > compilation on arm4/arm5 fails:
> > 
> > libavcodec/libavcodec.so: undefined reference to
> > `ff_startcode_find_candidate_armv6'
> > 
> > Because libavcodec/arm/Makefile contains
> > ARMV6-OBJS-$(CONFIG_STARTCODE)         += arm/startcode_armv6.o
> > function ff_startcode_find_candidate_armv6 is not included for older ARM
> > archs. The bug was found during automatic buildroot builds:
> > 
> > http://autobuild.buildroot.net/results/ec7/ec71e4f16ee9106747dff5f15999cbd17903e76f//build-end.log
> > Quote from configure summary:
> > ARCH                      arm (armv4t)
> > big-endian                no
> > runtime cpu detection     yes
> > ARMv5TE enabled           no
> > ARMv6 enabled             no
> > ARMv6T2 enabled           no
> > 
> > http://autobuild.buildroot.net/results/be7/be72eb182eaccf0064a32c9dfc2ac1c0d6555506/build-end.log
> > ARCH                      arm (armv5te)
> > big-endian                no
> > runtime cpu detection     yes
> > ARMv5TE enabled           yes
> > ARMv6 enabled             no
> > ARMv6T2 enabled           no
> > 
> > This patch provides the necessary #if clauses as discussed with Michael:
> > https://ffmpeg.org/pipermail/ffmpeg-devel/2014-September/163329.html
> > 
> > Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> > ---
> >  libavcodec/arm/h264dsp_init_arm.c |    2 ++
> >  libavcodec/arm/vc1dsp_init_arm.c  |    2 ++
> >  2 files changed, 4 insertions(+)
> 
> applied
> 
> thanks

btw, maybe you want to setup a arm4/5 fate client ?
so these kind of issues get detected and fixed quicker in the future

See: http://ffmpeg.org/fate.html

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140923/997bbfaa/attachment.asc>