[FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

[Benoit Fouet]

Hi,

----- Mail original -----
> On Tue, Sep 30, 2014 at 11:15:06AM +0200, Benoit Fouet wrote:
> > Hi,
> > 
> > ----- Mail original -----
> > > On Tue, Sep 30, 2014 at 09:45:47AM +0200, Benoit Fouet wrote:
> > > > Hi,
> > > > 
> > > > ----- Mail original -----
> > > > > On Mon, Sep 29, 2014 at 03:31:36PM +0200, Benoit Fouet wrote:
> > > > >
> > > > 
> > > > [...]
> > > > 
> > > > > does this ensure that the sps is before the pps ?
> > > > > if not that might be the reason for the warnings
> > > > > 
> > > > 
> > > > It does not. I can update this so that when the pps is seen and
> > > > not
> > > > the sps, it prepends the sps to the pps.
> > > 
> > > please do, sps should be before the pps
> > > 
> > 
> > Done, new patch attached.
> 
> probably ok, should i apply it ?
> 

I guess so. I have 2 more patches to this BSF, I'll send them shortly.

> 
> > Also, it would be cool if someone had a sample with only SPS in the
> > stream, to check that the copy of PPS from AVCC works fine too.
> 
> yes, but i suspect this could be more rare
> 

When/if we have one, we can test this anyway.

Thanks,
-- 
Ben