[FFmpeg-devel] [PATCH 4/4] avutil/mips/intreadwrite: build fix for mips64r6 (instruction 'lwl' not supported)

[Timothy Gu]

On Wed, Apr 1, 2015 at 6:56 AM <shivraj.patil at imgtec.com> wrote:

> From: Shivraj Patil <shivraj.patil at imgtec.com>
>
> Note:- This is a preparation patch to submit optimized code for msa(mips
> simd architecture).
>
> Signed-off-by: Shivraj Patil <shivraj.patil at imgtec.com>
> ---
>  libavutil/mips/intreadwrite.h | 2 ++
>  1 file changed, 2 insertions(+)
>


>  mode change 100644 => 100755 libavutil/mips/intreadwrite.h
>

Please revert this file mode change.


>
> diff --git a/libavutil/mips/intreadwrite.h b/libavutil/mips/intreadwrite.h
> old mode 100644
> new mode 100755
> index 9ba0491..8120c04
> --- a/libavutil/mips/intreadwrite.h
> +++ b/libavutil/mips/intreadwrite.h
> @@ -25,6 +25,7 @@
>  #include "config.h"
>
>

>  #if ARCH_MIPS64 && HAVE_INLINE_ASM
> +#if !HAVE_MIPS64R6
>

Why don't you merge these two #if's?


>
>  #define AV_RN32 AV_RN32
>  static av_always_inline uint32_t AV_RN32(const void *p)
> @@ -42,5 +43,6 @@ static av_always_inline uint32_t AV_RN32(const void *p)
>  }
>
>

>  #endif /* ARCH_MIPS64 && HAVE_INLINE_ASM */
> +#endif /* !HAVE_MIPS64R6 */
>

Comment order is wrong.

Timothy